Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper QOL improvements #32418

Merged

Conversation

eoineoineoin
Copy link
Contributor

About the PR

Minor QOL improvements for paper

  • Don't add newlines every time the player saves a paper
  • Show players how much space they have left in the paper
  • Don't allow players to attempt to save a paper which is over the max length (which previously lost the player's work)

Fixes #32344.
Fixes #32357.

Why / Balance

Filling forms is the most important part of the game.

Technical details

Boring UI juggling.

Media

Behaviour of UI when going over the content length limit (I've modified the max length to be 60, to make it easier to demo):

Peek.2024-09-23.19-18.mp4

Requirements

Breaking changes

Changelog

Eoin Mcloughlin added 2 commits September 23, 2024 18:24
* Display a "fill progress" indicator so users know how close they are to filling it
* Don't allow users to save a paper which went over the limit, to avoid them losing data they want to keep.
@github-actions github-actions bot added the Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design label Sep 23, 2024
@Moomoobeef
Copy link
Contributor

It's so satisfying to see a PR that solves multiple of my issues at once. 👍

@metalgearsloth metalgearsloth merged commit 594aad0 into space-wizards:master Sep 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saving a piece of paper adds a newline to the end. Always. The character limit on paper should be visible
3 participants