Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict inflatable barriers verb #32420

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

beck-thompson
Copy link
Contributor

About the PR

Moved the verb system and stuff into shared so you wouldn't get the annoying lag. Also cleaned up the old version of the do-after system and made it nice.

Technical details

See above! Nothing too crazy.

Media

2024-09-23.13-26-14.mp4

Breaking changes

If you have a DisassembleOnAltVerb the fields have been renamed:
prototype -> prototypeToSpawn
doAfter -> disassembleTime

If you just change the names everything else works exactly the same!

Changelog

🆑 Beck Thompson

  • fix: Inflatable barrier disassembly is not not laggy anymore.

}
_handsSystem.TryPickup(args.User, spawnedEnt);
// Only reason this is in server is because this isn't predicted.
EntityManager.DeleteEntity(entity.Owner);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a while to look this up, but appearently the way it is done elsewhere is to simply do if (_net.IsServer) in Shared, so do that and get rid of the whole server part. Also use QueueDel(entity.Owner) for deleting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is really odd is after doing this it looks MORE laggy! I don't understand it at all 😢
Also see my message in discord, apparently spawning something and picking it up also has warnings...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated this so I could do the Voice Mask stuff... Right now its "working" but still spitting out warnings and having issues! What I'm trying to say, DONT merge it 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I've tried experimenting, basically any prediction makes it somehow look worse and or error out so I just made it not predicted!

The way I did it is a little odd so if you want me to just directly move it to server let me know (It does work though and its nice that it's all in one files instead of two!)

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants