Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blunt damage will do stamina damage on wide attacks #32422

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

Calecute
Copy link
Contributor

@Calecute Calecute commented Sep 23, 2024

About the PR

Added stamina damage to right click wide arc attacks that do blunt damage

Why / Balance

Think it was a bug that blunt didn't do stamina on wide attacks, it's reported as a bug in #31693

Buffing wide against single is maybe kinda bad, but I think blunt should still do stamina in wide to keep blunt x pierce x cut balanced, and because it's unintuitive that it don't. Wide x single should be balanced in other ways.

This might be relevant to the new medical as it changes code dealing with damage.

Technical details

Just added a few lines checking for blunt damage and applying stamina damage to wide attacks, pretty similar to what single attacks had. in shared melee weapons system

Media

2024-09-23.19-21-59.mp4

Requirements

Breaking changes

Wide attacks now also do stamina damage for blunt damage.

Changelog

🆑

  • fix: wide attacks that deal blunt damage will now deal stamina damage.

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Sep 23, 2024
@Golinth
Copy link
Contributor

Golinth commented Sep 24, 2024

finally, I can use the truncheon as god intended

@whateverusername0
Copy link
Contributor

sounds ultra op

what if you took stamina damage when wide swinging?

@Golinth
Copy link
Contributor

Golinth commented Sep 25, 2024

sounds ultra op

what if you took stamina damage when wide swinging?

It’s already a thing, this just adds QOL by not needing to pixel hunt and allowing wideswings. How is it OP?

@Calecute
Copy link
Contributor Author

Yeah do note that blunt already do stamina damage when not wide swinging and truncheon is stronger than other blunt, it has a bonus blunt stamina damage.

As I said I think maybe wide doesn't need buffs against single. But they shouldn't be balanced by a exception to normal blunt stamina damage, because it doesn't really address the issue in general, just for blunt, it changes the balance between blunt and other damage types (since both will kill might as well ditch the truncheon for the fire axe), and it's a unexpected behavior that will confuse players, they will use wide truncheon expecting a less than lethal weapon and kill people. This just looks like a bug to me, not a intended way to keep wide balanced.

@metalgearsloth
Copy link
Contributor

Prolly fine to do it here ig, might want to move it at some point to staminasystem though that likely needs attackedevent tweaks.

@metalgearsloth metalgearsloth merged commit b7bd7c1 into space-wizards:master Oct 20, 2024
13 checks passed
@Futuristic-OK
Copy link
Contributor

Why you do it with wideswing? Single hit - perfect solve for it. This is more skill-dependent

iaada pushed a commit to iaada/space-station-14 that referenced this pull request Nov 9, 2024
)

Fix: blunt damage will now do stamina damage on wide attacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants