ciggie sounds #32426
Open
ciggie sounds #32426
+37
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gone are the days of me looking like an idiot trying to smoke a cigarette butt |
|
no media? |
|
trust |
Centronias
reviewed
Oct 15, 2024
Comment on lines
73
to
+80
| if (state == SmokableState.Lit) | ||
| _active.Add(uid); | ||
| EnsureComp<BurningComponent>(uid); | ||
| else | ||
| _active.Remove(uid); | ||
| RemComp<BurningComponent>(uid); | ||
|
|
||
| var sound = state == SmokableState.Lit | ||
| ? smokable.LightSound | ||
| : smokable.SnuffSound; |
There was a problem hiding this comment.
Suggested change
| if (state == SmokableState.Lit) | |
| _active.Add(uid); | |
| EnsureComp<BurningComponent>(uid); | |
| else | |
| _active.Remove(uid); | |
| RemComp<BurningComponent>(uid); | |
| var sound = state == SmokableState.Lit | |
| ? smokable.LightSound | |
| : smokable.SnuffSound; | |
| SoundSpecifier? sound = null; | |
| if (state == SmokableState.Lit) | |
| { | |
| EnsureComp<BurningComponent>(uid); | |
| sound = smokable.LightSound; | |
| } | |
| else | |
| { | |
| RemComp<BurningComponent>(uid); | |
| sound = smokable.SnuffSound; | |
| } |
considering the if and ternary have the same condition.
edit: realized I butchered the var sound bit -- I am not sure exactly what I've edited to is correct either, but you get the idea.
|
tryna smoke here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
plays a sound when lighting a ciggie or it goes out
Why / Balance
good
Technical details
replaced _active hashset with BurningComponent to track actively lit ciggies
Media
it work
Requirements