Fix contraband never getting added to vend inventory #32431
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes #32421
Technical details
The old code updated the server component, but not the client component. To ensure the values stay synced, instead of setting the component directly in the action, the action now calls a setter on the system, similarly to how CanShoot is set.
Other actions were not affected by this bug probably because all of them are event based. Emagging is event based and runs through a completely different pipeline which updates both components. But building the vend inventory happens in the shared system, and uses the client side component for it, leading to this bug.
Media
vendfix.mp4
Requirements
Changelog
🆑