Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cvars to votekick to customize requirements for the initiator. #32490

Conversation

VasilisThePikachu
Copy link
Member

@VasilisThePikachu VasilisThePikachu commented Sep 27, 2024

About the PR

Adds the votekick.initiator_time_requirement and votekick.initiator_whitelist_requirement
The defaults function exactly like the initial pr being false and true

Why / Balance

I noticed this now after review, idk how bad requiring whitelist for wizden will be and thats up to admins.

But im making this for forks who dont do whitelists of some kind.

Media

Requirements

@deathride58 deathride58 added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. Merge Conflict This PR currently has conflicts that need to be addressed. PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. labels Nov 1, 2024
@deathride58 deathride58 self-assigned this Nov 1, 2024
@VasilisThePikachu
Copy link
Member Author

VasilisThePikachu commented Nov 2, 2024

My... git client does not see these conflicts?????
I lied i did not have latest master

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Nov 2, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Nov 2, 2024
@deathride58
Copy link
Member

Git moment

@deathride58 deathride58 merged commit 957b8de into space-wizards:master Nov 2, 2024
12 checks passed
iaada pushed a commit to iaada/space-station-14 that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants