-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Examine Damage now specifies no damage #33064
Open
thetolbean
wants to merge
2
commits into
space-wizards:master
Choose a base branch
from
thetolbean:0-damage-examine
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Needs Review
This PR requires new reviews before it can be merged.
label
Oct 30, 2024
yeah, that's what i was trying to do in this system but couldn't figure it out, thanks! |
2 tasks
PursuitInAshes
approved these changes
Nov 2, 2024
chromiumboy
requested changes
Nov 10, 2024
chromiumboy
added
Status: Awaiting Changes
This PR needs its reviews addressed or changes to be made in order to be merged.
and removed
Status: Needs Review
This PR requires new reviews before it can be merged.
labels
Nov 10, 2024
github-actions
bot
added
Status: Needs Review
This PR requires new reviews before it can be merged.
and removed
Status: Awaiting Changes
This PR needs its reviews addressed or changes to be made in order to be merged.
labels
Nov 10, 2024
chromiumboy
added
PR: Approved
Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
and removed
Status: Needs Review
This PR requires new reviews before it can be merged.
labels
Nov 11, 2024
Looks good, tested in game fine. Thanks for the fix |
chromiumboy
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: Approved
Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
PR: Bug Fix
Fixes a clear bug, no refactoring or features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
When you examine an item that is a weapon, but has no damage, IE a plushie, it now specifies that it does no damage.
May be paired with a revert of #33061 to once again show plushie 'damage'
Why / Balance
Shows that the examined item is a weapon but does no damage.
Fix #33052 (Second try)
Technical details
Checks the items damage dictionary to check if there is only one damage type and if that damage is 0.
Returns specific "no damage" message
Media
Requirements
Changelog
🆑