Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Examine Damage now specifies no damage #33064

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thetolbean
Copy link
Contributor

@thetolbean thetolbean commented Oct 30, 2024

About the PR

When you examine an item that is a weapon, but has no damage, IE a plushie, it now specifies that it does no damage.
May be paired with a revert of #33061 to once again show plushie 'damage'

Why / Balance

Shows that the examined item is a weapon but does no damage.
Fix #33052 (Second try)

Technical details

Checks the items damage dictionary to check if there is only one damage type and if that damage is 0.
Returns specific "no damage" message

Media

{35C8CA65-FA1E-4592-9019-5508252996CC}

Requirements

Changelog
🆑

  • fix: Items with a damage of 0 now have correct damage examination text.

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Oct 30, 2024
@lzk228
Copy link
Contributor

lzk228 commented Oct 30, 2024

yeah, that's what i was trying to do in this system but couldn't figure it out, thanks!
also you might revert the hiding damage from plushies
but it's the thing for discussions, should new players know that plushie can be used as a weapon though without a damage?

@chromiumboy chromiumboy self-assigned this Nov 10, 2024
@chromiumboy chromiumboy added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Nov 10, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Nov 10, 2024
@thetolbean thetolbean marked this pull request as draft November 10, 2024 21:21
@thetolbean thetolbean marked this pull request as ready for review November 10, 2024 21:21
@chromiumboy chromiumboy added PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Nov 11, 2024
@chromiumboy
Copy link
Contributor

Looks good, tested in game fine. Thanks for the fix

@chromiumboy chromiumboy added the PR: Bug Fix Fixes a clear bug, no refactoring or features label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. PR: Bug Fix Fixes a clear bug, no refactoring or features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

damage examine should not be available if the damage is zero
4 participants