-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contraband system for reagents #33184
base: master
Are you sure you want to change the base?
Conversation
Could in theory also encode the "GrandTheft" severity. Could make for an interesting objective: "Steal 10u of liquid youth from the command bar/vault.". |
Not in the scope of this PR, but perhaps there should be a new contraband category for prescription drugs that doctors are allowed to grant permission to possess. |
holy guacamole a reason to use forensic pads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful feature in my opinion. I found a few nitpicks that need to be corrected. I will check with the other maintainers and admins if this implementation is a good approach since the contraband system is quite connected to our server rules.
The failed test |
About the PR
This PR adds the ability to classify reagents and their contraband status with the help of forensic pads.
Fixes #31383
Fixes #32218
(there where more issues, but i can't find them)
Why / Balance
It was previously not possible to mark a reagent as contraband.
I have only added lead, romerol, vestine and its derivatives as syndicate contraband for the start as I feel those are uncontroversial.
Technical details
Media
Screencast.From.2024-11-05.20-49-41.mp4
Screencast.From.2024-11-06.13-53-11.mp4
Requirements
Breaking changes
None.
Changelog
🆑