Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contraband system for reagents #33184

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Ian321
Copy link
Contributor

@Ian321 Ian321 commented Nov 5, 2024

About the PR

This PR adds the ability to classify reagents and their contraband status with the help of forensic pads.

Fixes #31383
Fixes #32218

(there where more issues, but i can't find them)

Why / Balance

It was previously not possible to mark a reagent as contraband.

I have only added lead, romerol, vestine and its derivatives as syndicate contraband for the start as I feel those are uncontroversial.

Technical details

  • Modified the ForensicPadSystem to "scan" drainable/drawable containers (puddles, beakers, syringes, ...).
  • Added a new datafield "Contraband" to reagents. (I would of loved to re-use the other system, but reagents can't have components.)
    • Set it to "Syndicate" for Lead, Stimulants(Hyperzine), Nocturine, MuteToxin, Lexorin, Romerol, Vestine and Tazinide
  • Expanded the guidebook entry for forensics.
  • Expanded the guidebook for chemicals.

Media

Screencast.From.2024-11-05.20-49-41.mp4
Screencast.From.2024-11-06.13-53-11.mp4

Requirements

Breaking changes

None.

Changelog

🆑

  • add: Chemicals can now be contraband.
  • add: Forensic pads can now be used to classify chemicals.

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Nov 5, 2024
@Ian321
Copy link
Contributor Author

Ian321 commented Nov 5, 2024

Could in theory also encode the "GrandTheft" severity. Could make for an interesting objective: "Steal 10u of liquid youth from the command bar/vault.".

@YotaXP
Copy link

YotaXP commented Nov 5, 2024

Not in the scope of this PR, but perhaps there should be a new contraband category for prescription drugs that doctors are allowed to grant permission to possess.

@Djungelskog2
Copy link

holy guacamole a reason to use forensic pads

@Ian321 Ian321 marked this pull request as draft November 6, 2024 12:01
@github-actions github-actions bot added the Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design label Nov 6, 2024
@Ian321 Ian321 marked this pull request as ready for review November 6, 2024 13:00
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful feature in my opinion. I found a few nitpicks that need to be corrected. I will check with the other maintainers and admins if this implementation is a good approach since the contraband system is quite connected to our server rules.

Content.Shared/Chemistry/Reagent/ReagentPrototype.cs Outdated Show resolved Hide resolved
Content.Server/Forensics/Systems/ForensicPadSystem.cs Outdated Show resolved Hide resolved
Content.Server/Forensics/Systems/ForensicPadSystem.cs Outdated Show resolved Hide resolved
Content.Server/Forensics/Systems/ForensicPadSystem.cs Outdated Show resolved Hide resolved
@slarticodefast slarticodefast self-assigned this Nov 7, 2024
@slarticodefast slarticodefast added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Nov 7, 2024
@Ian321
Copy link
Contributor Author

Ian321 commented Nov 7, 2024

The failed test DeleteAllThenGhost is unrelated and passed on my machine.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged. Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Controlled Substances" is a myth Chemicals and the new contraband system
4 participants