Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dna from skeletons #33207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove dna from skeletons #33207

wants to merge 1 commit into from

Conversation

pheenty
Copy link
Contributor

@pheenty pheenty commented Nov 7, 2024

About the PR

moved dna component from basemobspecies to basemobspeciesorganic, effectively removing it from skeletons

Why / Balance

why do skeletons even have dna? especially when they have no fingerprints
well, because it was left over in #30530

Technical details

no

Media

no

Requirements

Breaking changes

i believe none
Changelog
no

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. No C# For things that don't need code. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Nov 7, 2024
@slarticodefast
Copy link
Member

Don't bones technically have DNA?

@pheenty
Copy link
Contributor Author

pheenty commented Nov 7, 2024

Don't bones technically have DNA?

Well, bones do, but in the game the only time a skeleton can leave it's dna is when stabbing itself with an implanter between the ribs (which it shouldn't be able to do in the first place). And when (or, rather, if) ipcs or other inorganic species gets added, they will definetely not have any dna in them

@pheenty pheenty changed the title move dna to basemobspeciesorganic remove dna from skeletons Nov 7, 2024
@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code. Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants