Fixes StoredOffset not affecting StoredSprite #33212
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Makes it so specifying a StoredOffset in ItemComponent actually affects a specified StoredSprite
Why / Balance
Ive been making more storage sprites for grid inv, and I noticed when I tried to make offset adjustments that if you are using a unique sprite for a grid inv icon that it is unaffected by offset.
Technical details
To be clear, the StoredOffset specifically works perfectly fine when a unique storage sprite is not specified. This is because the value calculated using the StoredOffset value is only used in the code block of an If/Else statement for when a storage sprite is not specified. I didnt think too hard about this one and just stuck the values in but its a small fix so im sure its fine.
Media
Requirements
Breaking changes
Changelog
No CL needed.