Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vape use without check if doafter cancelled #33245

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

leonidussaks
Copy link
Contributor

About the PR

Fixed a small bug that allowed players to use vape without waiting for the doafter action delay just clicking on a character second time.

Technical details

Just check if doafter cancelled

Media

bug.mp4
fixed.mp4

Requirements

Changelog

Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the bugfix and your first contribution!

@slarticodefast slarticodefast self-assigned this Nov 10, 2024
@slarticodefast slarticodefast added the PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. label Nov 10, 2024
@chromiumboy
Copy link
Contributor

chromiumboy commented Nov 11, 2024

Thanks for the fix, tested in-game fine

I did note some issues with vapes outside the scope of this PR that I'll record for prosperity. First, using the vape consumes all the liquid inside it, which is a waste of water since it can hold 10 u before becoming full and the minimum transferable amount is 5 u. It also means that the vape needs to be topped up after every puff, which seems odd. Second, if you transfer in 10 u, use it, then refill it with only 5 u, there will be pop up stating the vape is full when it isn't yet

@chromiumboy chromiumboy merged commit 21979a7 into space-wizards:master Nov 11, 2024
12 checks passed
@leonidussaks leonidussaks deleted the vape_small_fix branch November 11, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants