Skip to content

Commit

Permalink
feat: define Add, Sub and Mul for OwnedColumn (#74)
Browse files Browse the repository at this point in the history
# Rationale for this change
This PR is split out from #70 since it has become too large. The actual
content of this PR (that is, what's not in #70) is here:
e166762
<!--
Why are you proposing this change? If this is already explained clearly
in the linked Jira ticket then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

# What changes are included in this PR?

- Define `Add`, `Sub` and `Mul` for `OwnedColumn`

<!--
There is no need to duplicate the description in the ticket here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

# Are these changes tested?
Yes.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
  • Loading branch information
iajoiner authored Aug 2, 2024
1 parent c2d0204 commit 2fd9fe1
Show file tree
Hide file tree
Showing 3 changed files with 717 additions and 1 deletion.
1 change: 0 additions & 1 deletion crates/proof-of-sql/src/base/database/column_operation.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![allow(dead_code)]
use super::{ColumnOperationError, ColumnOperationResult};
use crate::base::{
database::ColumnType,
Expand Down
2 changes: 2 additions & 0 deletions crates/proof-of-sql/src/base/database/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ mod owned_column;
pub(crate) use owned_column::compare_indexes_by_owned_columns_with_direction;
pub use owned_column::OwnedColumn;

pub(crate) mod owned_column_operation;

mod owned_table;
pub use owned_table::OwnedTable;
pub(crate) use owned_table::OwnedTableError;
Expand Down
Loading

0 comments on commit 2fd9fe1

Please sign in to comment.