Remove query! macro.

[JayWhite2357]

Background and Motivation

Rust macros are a bit of a anti-pattern. In particular, the query! macro, which is used as a testing utility macro to test QueryExpr, obfuscates the tests.

Changes Required

• Remove uses of the query! macro and replace it with explicit uses of the tested methods. For example,

  sxt-proof-of-sql/crates/proof-of-sql/src/sql/parse/query_expr_tests.rs

  Lines 1166 to 1170 in e2eb590

  	let query = query!(
  	select: ["max(i) max_sal", "i0 d", "count(i0)"],
  	group: ["i0", "i1"],
  	order: ["max_sal"]
  	);

  can be replaced by

  let query_text = "select max(i) max_sal, i0 d, count(i0) from t group by i0, i1 order by max_sal";
  let (t, accessor) = get_test_accessor();
  let intermediate_ast = SelectStatementParser::new().parse(query_text).unwrap();
  let query = QueryExpr::<NaiveCommitment>::try_new(intermediate_ast, t.schema_id(), &accessor).unwrap();

• Refactor or remove get_test_accessor so that it is explicit what the tables, columns, and data types are in the SchemaAccessor. For example, the above query has a t table with the columns i, i0, and i1, all with BigInt type. These columns should also be renamed to be slightly less generic and/or more helpful.
• Remove the query! macro.

NOTE: the macro is almost exclusively a macro that builds the query text. The actual functionality being tested should be essentially unchanged.

[JayWhite2357]

/bounty $50

[algora-pbc]

💎 $50 bounty • Space and Time

Steps to solve:

1. Start working: (Optional) Comment /attempt #236 with your implementation plan. Note: we will only assign an issue if you include an implementation plan with a time estimate. Additionally, to be assigned an issue, you must have previously contributed to the project. You can still work on an issue and submit a PR without being assigned.
2. Submit work: Create a pull request including /claim #236 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to spaceandtimelabs/sxt-proof-of-sql!

Add a bounty • Share on socials

Attempt	Started (GMT+0)	Solution
🟢 @Harsh9485	Oct 15, 2024, 10:33:45 AM	WIP
🟢 @akhilender-bongirwar	Nov 1, 2024, 3:42:19 AM	#284

[Harsh9485]

/attempt #236

Options

• Cancel my attempt

[algora-pbc]

💡 @akhilender-bongirwar submitted a pull request that claims the bounty. You can visit your bounty board to reward.

[github-actions]

🎉 This issue has been resolved in version 0.34.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[akhilender-bongirwar]

@JayWhite2357 I did not receive the bounty. I think you need to approve it on the Algora dashboard.

[akhilender-bongirwar]

@JayWhite2357 I did not receive the bounty. I think you need to approve it on the Algora dashboard.

// @iajoiner

[akhilender-bongirwar]

/attempt #236

Maybe I didn't do this before that might be reason I was not awarded the bounty but it is written optional in the guidelines.

Algora profile	Completed bounties	Tech	Active attempts	Options
@akhilender-bongirwar	5 bounties from 4 projects	TypeScript, JavaScript, C++ & more		Cancel attempt

[algora-pbc]

🎉🎈 @akhilender-bongirwar has been awarded $50! 🎈🎊

• Share on socials
• Give feedback