Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove query! macro and replace #285

Closed

Conversation

Harsh9485
Copy link

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

Fixes #236
/claim #236

This PR addresses part 1 of #236 by removing the use of the query! macro in tests and replacing it with explicit construction of the query expressions.

What changes are included in this PR?

  • Removed instances of the query! macro from the test files, specifically in sxt-proof-of-sql/crates/proof-of-sql/src/sql/parse/query_expr_tests.rs
  • Replaced the macro usage with explicit query construction

Are these changes tested?

Yes

@algora-pbc algora-pbc bot mentioned this pull request Oct 21, 2024
3 tasks
Copy link

algora-pbc bot commented Oct 21, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@iajoiner iajoiner changed the title remove query! macro and replace refactor: remove query! macro and replace Oct 21, 2024
@akhilender-bongirwar
Copy link
Contributor

@Harsh9485, The part 1 and part 3 of this issue are already fixed in my PR #261

@Harsh9485 Harsh9485 closed this by deleting the head repository Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove query! macro.
2 participants