feat: add AddSubtractExpr
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/add-sub
branch
4 times, most recently
from
f2133e5
to
f38ae8d
Compare
iajoiner
force-pushed
the
feat/add-sub
branch
3 times, most recently
from
6171344
to
ed54c25
Compare
iajoiner
force-pushed
the
feat/add-sub
branch
4 times, most recently
from
8c2a74c
to
55e22a4
Compare
iajoiner
force-pushed
the
feat/add-sub
branch
7 times, most recently
from
cacde58
to
b754d70
Compare
iajoiner
force-pushed
the
feat/add-sub
branch
3 times, most recently
from
613d385
to
18488fd
Compare
iajoiner
force-pushed
the
feat/add-sub
branch
2 times, most recently
from
0da590e
to
2b1f2a1
Compare
|
See #20 (in particular, the and_expr_test.rs file) for how I think we should have the tests look going forward. |
iajoiner
force-pushed
the
feat/add-sub
branch
2 times, most recently
from
025cd19
to
5dd3605
Compare
iajoiner
force-pushed
the
feat/add-sub
branch
6 times, most recently
from
9c23c26
to
75a4b23
Compare
JayWhite2357
previously approved these changes
Jun 21, 2024
JayWhite2357
previously approved these changes
Jun 21, 2024
iajoiner
force-pushed
the
feat/add-sub
branch
2 times, most recently
from
76f699e
to
371993a
Compare
- add `AddSubExpr` and enable + and - elsewhere - generalize `scale_and_subtract_eval` to `scale_and_add_subtract_eval` - make sure we pass in scales in any operation that can involve decimals
JayWhite2357
approved these changes
Jun 21, 2024
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need to add support for arithmetic. Let's start from + and -.
What changes are included in this PR?
proof-of-sqlcratescale_and_subtract_evaltoscale_and_add_subtract_evalAre these changes tested?
Yes.