refactor: switch to consume_intermediate_mle in ProofPlan::verifier_evaluate
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
changed the title
is_top_level to prover_evaluate and verifier_evaluate for ProofPlansis_top_level to prover_evaluate and verifier_evaluate for ProofPlans
iajoiner
force-pushed
the
refactor/mles
branch
from
6c8f329
to
49b64de
Compare
iajoiner
force-pushed
the
refactor/mles
branch
2 times, most recently
from
28c2e74
to
35de9cc
Compare
There was a problem hiding this comment.
My biggest concert here is that a node could produce a different number of intermediate mles and result mles, depending on whether it is top level or not. This would mean that consume_result_or_intermediate_mle doesn't really cover all cases.
I don't have a great solution to this problem, but I don't think this is the correct one.
iajoiner
force-pushed
the
refactor/mles
branch
3 times, most recently
from
cb20a4e
to
ced1b34
Compare
iajoiner
changed the title
is_top_level to prover_evaluate and verifier_evaluate for ProofPlansconsume_intermediate_mle in ProofPlan::verifier_evaluate
iajoiner
force-pushed
the
refactor/mles
branch
4 times, most recently
from
9353ad4
to
51e87eb
Compare
iajoiner
force-pushed
the
refactor/mles
branch
5 times, most recently
from
33b5144
to
994fbe1
Compare
iajoiner
force-pushed
the
refactor/mles
branch
3 times, most recently
from
e4cb1ec
to
8d653b9
Compare
iajoiner
force-pushed
the
refactor/mles
branch
4 times, most recently
from
56b7695
to
8e8acf9
Compare
iajoiner
force-pushed
the
refactor/mles
branch
2 times, most recently
from
6b90319
to
039d52e
Compare
iajoiner
force-pushed
the
refactor/mles
branch
from
1b2a631
to
9d25ec3
Compare
JayWhite2357
previously approved these changes
Oct 4, 2024
…r_evaluate` - `ProofPlan` change above - remove `consume_result_mle` from `VerificationBuilder`
iajoiner
force-pushed
the
refactor/mles
branch
from
9d25ec3
to
418bf75
Compare
iajoiner
force-pushed
the
refactor/mles
branch
from
418bf75
to
4dfae4a
Compare
JayWhite2357
approved these changes
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to accommodate composition of
ProofPlans we need to allow either result or intermediate MLEs to be used depending on whether the plan is at top level.What changes are included in this PR?
consume_intermediate_mleinProofPlan::verifier_evaluateAre these changes tested?
Existing tests should pass