-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the separated big_decimal_ext #196
Added the separated big_decimal_ext #196
Conversation
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
…utils due to cyclic dependency problem
…ni/sxt-proof-of-sql into big_decimal_addition
It doesn't look like Am I missing something here? |
@pulkitgovrani I believe that this PR is almost complete. It was very close and just needs a bit of updating. Is there any clarification you need at this point? |
@pulkitgovrani Closing because I don't see activity on this. Feel free to reopen when it becomes ready. |
/claim #113
Suggested Solution:
Creating a new big_decimal_ext file in the math section inside proof_of_sql folder & pushing the code conversion there.
Problem Faced by me while implementing above solution:
I was getting circular dependency error while doing cargo build because proof-of-sql would become dependent on proof-of-sql-parser and vice versa.
Therefore, to overcome this problem I created a new folder proof-of-sql-utils containing the file code required by both other modules.
Please do share the feedback