feat: make polars postprocessing optional behind feature flag #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
changed the title
iajoiner
previously approved these changes
Jul 3, 2024
iajoiner
force-pushed
the
feat/polars-feature-flag
branch
from
fde305e
to
086f33c
Compare
- remove arrow and polars usage from `sql::ast` - remove `TestExprNode` - move polars-related constants to `sql::transform`
iajoiner
force-pushed
the
feat/polars-feature-flag
branch
from
086f33c
to
a28d613
Compare
iajoiner
force-pushed
the
feat/polars-feature-flag
branch
from
a28d613
to
30ae609
Compare
|
Closed since we plan to immediately remove polars |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to eliminate polars we should first put it behind a feature flag.
What changes are included in this PR?
Are these changes tested?
Existing tests do pass