-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: timestamp literal support #22
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dustin-Ray
commented
Jun 21, 2024
Dustin-Ray
commented
Jun 21, 2024
Dustin-Ray
changed the title
Feat/timestamp literal support
feat!: timestamp literal support
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ISO 8601-compliant timestamp parsing
For fully-featured timestamp support, we want to align with ISO-8601 as closely as possible with respect to parsing timestamp queries.
Proposed parsing strategy:
Pull a string literal from the lexer and then try to parse that string directly, instead of defining separate timestamp literals in the lexer, which can become tricky. Currently, we are directly parsing timezone literals only for the purpose of testing. An ambiguous gra
What changes are included in this PR?
Current Capabilities
2024-06-20 12:34:56.123456789+02:00
2024-06-20 12:34:56.123456789Z
2024-06-20 12:34:56.123456789
2024-06-20 12:34:56+02:00
2024-06-20 12:34:56Z
2024-06-20 12:34:56
To-Do List for Full ISO 8601 Compliance
20240620T123456Z
20240620T123456+02:00
2024-06-20
20240620
12:34:56
123456
12:34:56.123456789
2024-W25-4
(The 4th day of the 25th week of 2024)2024-171
(The 171st day of 2024)Additional Considerations
Are these changes tested?
working on it, as soon as the lexer is updated we can start making round trip queries and integration tests