feat: read and write prover public setup parameters from file #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dustin-Ray
force-pushed
the
feat/prover-public-params-file-ops
branch
from
844c9b4
to
f36b7ec
Compare
Dustin-Ray
force-pushed
the
feat/prover-public-params-file-ops
branch
from
b308678
to
856b238
Compare
iajoiner
reviewed
Oct 7, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
iajoiner
reviewed
Oct 7, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
iajoiner
reviewed
Oct 7, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
iajoiner
reviewed
Oct 7, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
iajoiner
reviewed
Oct 7, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
iajoiner
reviewed
Oct 7, 2024
iajoiner
approved these changes
Oct 7, 2024
|
🎉 This PR is included in version 0.28.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
PublicParameterssetup phase involves the calculation of multiple large vectors of group elements in order to instantiate the argument system. The setup phase can potentially be costly in some configurations. The setup phase is transparent and can be cached for later use. This PR adds support for file i/o forPublicParametersalong with serde.Currently the file i/o and serialization are gated behind std in order to conform to a
no_stdrequirement. There might be a more appropriate way to handle this, but currently this allows std enabled test code to easily generate a setup of a configurable size.What changes are included in this PR?
Are these changes tested?