refactor!: add get_table_references, get_output_length and modify get_length
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/output-length
branch
from
5273928
to
2ff406d
Compare
iajoiner
force-pushed
the
feat/output-length
branch
3 times, most recently
from
94f55ba
to
5b1297f
Compare
iajoiner
changed the title
get_output_length and modify get_lengthget_table_references, get_output_length and modify get_length
iajoiner
force-pushed
the
feat/output-length
branch
3 times, most recently
from
d9a17ec
to
a391e88
Compare
iajoiner
force-pushed
the
feat/output-length
branch
from
a391e88
to
26620b1
Compare
iajoiner
force-pushed
the
feat/output-length
branch
5 times, most recently
from
9d8d304
to
f41989f
Compare
iajoiner
requested review from
JayWhite2357
and removed request for
JayWhite2357
iajoiner
force-pushed
the
feat/output-length
branch
from
f41989f
to
bb1329c
Compare
…` to `get_input_lengths` - add `ProverEvaluate::get_output_length` - rename `get_length` to `get_input_lengths` - move `get_input_lengths` to `ProverEvaluate` - add `get_table_references`
iajoiner
force-pushed
the
feat/output-length
branch
2 times, most recently
from
deaa601
to
163c3fa
Compare
iajoiner
force-pushed
the
feat/output-length
branch
from
163c3fa
to
d5a22ec
Compare
|
Closed in favor of a new approach using #334 which will remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
In order to make
ProofPlans composableget_lengthhas to depend on more than lengths of existing tables. Hence it is necessary to move it toProverEvaluate. Moreover we want to support multiple tables. Hence let's addget_table_referencesandget_input_lengths.What changes are included in this PR?
ProverEvaluate::get_output_lengthget_lengthtoProverEvaluate, rename it toget_input_lengthsand change its parametersProofPlan::get_table_referencesAre these changes tested?
Yes