-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor:Tidy up scalar module #251
refactor:Tidy up scalar module #251
Conversation
Thanks for the PR! It looks like the CI isn't passing. To expedite the review process, you can run the CI locally to ensure you fix the formatting/clippy issues: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#user-content-code-quality-checks. |
Thank you for the feedback! I’ll run the CI checks locally again to address the formatting and Clippy issues as suggested. I’ll make sure everything is in order before resubmitting the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This PR is included in version 0.28.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Rationale for this change
Mentioned in #234
What changes are included in this PR?
Combine any logic held within the four files "mont_scalar", "mont_scalar_from", "mont_scalar_test", "mont_scalar_from_test" into two files "mont_scalar" and "mont_scalar_test"
EDIT: this is part of #234, but does not complete it.