refactor:Tidy up scalar module #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarttimwhite
previously requested changes
Oct 14, 2024
…ql into winrhcp-issue-234
Yes, I have already changed the file name to scalar.rs. Let me know if you'd like further adjustments! |
JayWhite2357
requested changes
Oct 19, 2024
Co-authored-by: Jay White <[email protected]>
Co-authored-by: Jay White <[email protected]>
JayWhite2357
approved these changes
Oct 19, 2024
JayWhite2357
approved these changes
Oct 19, 2024
|
/approve |
|
Could not find a claim that corresponds to the PR. Please add the |
|
🎉 This PR is included in version 0.31.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Mentioned in #234
What changes are included in this PR?
Move the Scalar trait to its own "scalar" file within base/scalar.
/claim #234