feat!: replace proof-of-sql-parser with sqlparser #286
Conversation
varshith257
changed the title
varshith257
force-pushed
the
add-sqlparser
branch
from
93efa97 to
92c4cf4
Compare
| @@ -11,8 +11,15 @@ use crate::{ | |||
| }, | |||
| }; | |||
| use alloc::{fmt, vec, vec::Vec}; | |||
| use proof_of_sql_parser::{intermediate_ast::SetExpression, Identifier, SelectStatement}; | |||
| use proof_of_sql_parser::{ | |||
There was a problem hiding this comment.
Since we're still depending on this crate here, we cannot delete the proof-of-sql-parser crate yet.
Once try_new_from_sqlparser can be used as a replacement for the old method, we can slowly remove the dependencies here.
There was a problem hiding this comment.
@JayWhite2357 I think @iajoiner has stated a few alternatives. I will check with the existing documentation and will proceed with the next steps outlined first to replace Identifier with sqlparser::ast::ident
There was a problem hiding this comment.
Sorry! I haven't looked at this #235 (comment) :) Ok I will follow the commented approach
| @@ -4,9 +4,8 @@ | |||
| * https://docs.rs/vervolg/latest/vervolg/ast/enum.Statement.html | |||
| ***/ | |||
|
|
|||
| use crate::{posql_time::PoSQLTimestamp, Identifier}; | |||
| use crate::{intermediate_decimal::IntermediateDecimal, posql_time::PoSQLTimestamp, Identifier}; | |||
There was a problem hiding this comment.
We don't have IntermediateDecimal any more which should make things easier.
|
@varshith257 Please rebase since our code base has changed pretty significantly. |
|
Sure! |
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
Part of #235
What changes are included in this PR?
Are these changes tested?
Docs Reference:
https://docs.rs/sqlparser/latest/sqlparser/ast/