feat!: make public_parameters extendable #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
requested review from
Dustin-Ray,
tlovell-sxt,
stuarttimwhite and
iajoiner
iajoiner
approved these changes
Oct 21, 2024
iajoiner
force-pushed
the
feat/extendable-pp
branch
from
3a4ccef
to
8b55127
Compare
tlovell-sxt
approved these changes
Oct 21, 2024
|
🎉 This PR is included in version 0.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Dory public parameters should be compatible between various choices of
max_nu. Currently, this is not the case.What changes are included in this PR?
Reorganize the generation of
PublicParametersso thatmax_nuonly extends it, instead of otherwise modifying it.Are these changes tested?
NA