perf: dynamic Dory commitment computation on the GPU should efficiently handle the offset #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he offset to avoid unnecessary computation
JayWhite2357
requested changes
Oct 21, 2024
crates/proof-of-sql/src/proof_primitive/dory/blitzar_metadata_table.rs
Outdated
Show resolved
Hide resolved
|
@jacobtrombetta just run cargo format or the check script and then if @JayWhite2357 is good with tests we can merge |
|
🎉 This PR is included in version 0.33.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently the dynamic Dory commitment computation on the GPU includes zeros for all offset values. This means adding a single commit with a large offset will require a significant chunk of unnecessary memory. This PR handles offsets more efficiently truncating all zero rows of the dynamic Dory structure matrix when crating the Blitzar metadata tables.
What changes are included in this PR?
blitzar_metadata_tablesmodule now truncates rows of the dynamic Dory structure matrix that are fully contained in the offset.blitzar_metadata_tablesmodule to test the new behavior.Gamma_2value in thedynamic_dory_commitment_helper_gpumodule now uses the offset.Are these changes tested?
Yes