feat: add space example
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
commented
Oct 22, 2024
Dustin-Ray
reviewed
Oct 22, 2024
Comment on lines
+24
to
+33
| // We generate the public parameters and the setups used by the prover and verifier for the Dory PCS. | ||
| // The `max_nu` should be set such that the maximum table size is less than `2^(2*max_nu-1)`. | ||
| // For a sampling: | ||
| // max_nu = 3 => max table size is 32 rows | ||
| // max_nu = 4 => max table size is 128 rows | ||
| // max_nu = 8 => max table size is 32768 rows | ||
| // max_nu = 10 => max table size is 0.5 million rows | ||
| // max_nu = 15 => max table size is 0.5 billion rows | ||
| // max_nu = 20 => max table size is 0.5 trillion rows | ||
| // Note: we will eventually load these from a file. |
There was a problem hiding this comment.
I like these comments a lot
Dustin-Ray
approved these changes
Oct 22, 2024
iajoiner
approved these changes
Oct 22, 2024
JayWhite2357
force-pushed
the
feat/add-space-example
branch
from
46824f8
to
56b90cf
Compare
JayWhite2357
force-pushed
the
feat/add-space-example
branch
from
56b90cf
to
c2496e0
Compare
|
🎉 This PR is included in version 0.33.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
More examples in the repo provide better documentation as well as provide some regression testing on top of other tests.
What changes are included in this PR?
An example (related to space) of reading tables for a csv file is provided along with various queries against those tables.
Are these changes tested?
Yes