feat: proversetup fileio #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
previously approved these changes
Oct 22, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
iajoiner
approved these changes
Oct 22, 2024
JayWhite2357
approved these changes
Oct 22, 2024
|
🎉 This PR is included in version 0.33.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR adds support for a conversion from pre-generated public parameters and a blitzar handle into a ProverSetup. This helps skip an expensive step to generate parameters and should significantly decrease the amount of time to load the parameters. It serves as a step towards file i/o for the parameters.
What changes are included in this PR?
Are these changes tested?
existing tests pass. a round trip test is forthcoming in a future PR.