feat: cat breads example #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SxTSimoneHaddad, thanks for the PR, would you mind Updating to Main with a rebase, then resolving the merge conflicts so we can merge this? Thank you. |
Dustin-Ray
reviewed
Oct 29, 2024
Comment on lines
+127
to
+128
| - name: Run cat breeds example | ||
| run: cargo run --example cat_breeds |
There was a problem hiding this comment.
This change is no longer needed and can safely be reverted
Dustin-Ray
reviewed
Oct 29, 2024
| @@ -244,4 +246,4 @@ jobs: | |||
| - name: Install solhint | |||
| run: npm install -g solhint | |||
| - name: Run tests | |||
| run: solhint -c 'crates/proof-of-sql/.solhint.json' 'crates/proof-of-sql/**/*.sol' -w 0 | |||
| run: solhint -c 'crates/proof-of-sql/.solhint.json' 'crates/proof-of-sql/**/*.sol' -w 0 | |||
There was a problem hiding this comment.
NIT: please add a new line here
Dustin-Ray
reviewed
Oct 29, 2024
| &prover_setup, | ||
| &verifier_setup, | ||
| ); | ||
| } |
There was a problem hiding this comment.
NIT: please add a new line here, this is likely fixed by running
cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Added Example - Cat breads - Add an additional breads example to help improve documentation.
What changes are included in this PR?
cat breads example is added.
Are these changes tested?
Yes.