feat: add aggregation-related intermediate AST conversions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/aggregate
branch
4 times, most recently
from
c0a364a
to
22d4c40
Compare
- add `AggregateExpr` which allows expressions such as `sum(a+b)` to become `ProvableExprPlan` - allow `Expression` -> `ProvableExprPlan` for aggregations
JayWhite2357
approved these changes
Jun 28, 2024
|
🎉 This PR is included in version 0.3.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is the first PR in generalization of
GroupByExpr. Following conventions from datafusion we allowAggregateExprso that provable aggregations can be expressed inProvableExprPlanand provide relevant conversion.What changes are included in this PR?
AggregateExprwhich allows expressions such assum(a+b)to becomeProvableExprPlanExpression->ProvableExprPlanfor aggregationsAre these changes tested?
Existing tests should pass.