feat: add basic sqlparser adaptions #338
Open
+273
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/adapt-sqlparser
branch
8 times, most recently
from
968124d
to
fbde9db
Compare
iajoiner
force-pushed
the
feat/adapt-sqlparser
branch
2 times, most recently
from
5c949d7
to
40794eb
Compare
iajoiner
force-pushed
the
feat/adapt-sqlparser
branch
from
40794eb
to
4580d0a
Compare
JayWhite2357
requested changes
Nov 6, 2024
| Literal::Int128(n) => Value::Number(n.to_string(), false), | ||
| Literal::Decimal(n) => Value::Number(n.to_string(), false), | ||
| Literal::Boolean(b) => Value::Boolean(b), | ||
| Literal::Timestamp(_ts) => todo!(), |
There was a problem hiding this comment.
Can you make this an Expr::TypedString? This is what sqlparser does. Then, this should be impl From<Literal> for Expr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
In order to allow #235 to be done in time for JOIN-related integrations we need to get
proof-of-sql-parser->sqlparseradaptions done. Large parts of the work going forward can then become more manageable.What changes are included in this PR?
sqlparser.rswith adaptationsAre these changes tested?
Yes