refactor: simplify result_evaluations calculation
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
force-pushed
the
refactor/simple-result-eval
branch
from
b817779
to
827a8e2
Compare
JayWhite2357
requested review from
iajoiner
and removed request for
tlovell-sxt
iajoiner
approved these changes
Nov 17, 2024
|
🎉 This PR is included in version 0.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to port the verifier to Solidity, some simplifications should be made to the Rust verifier to keep the implementations as similar as possible.
What changes are included in this PR?
The
result_evaluationscalculation inQueryProof::verifyis simplified.Are these changes tested?
Yes, by existing tests.