feat: generalize DenseFilterExpr
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/generalize-dense-filter-expr
branch
3 times, most recently
from
d818dcb
to
124c93a
Compare
iajoiner
force-pushed
the
feat/generalize-dense-filter-expr
branch
4 times, most recently
from
656c36d
to
94bc09b
Compare
iajoiner
force-pushed
the
feat/generalize-dense-filter-expr
branch
3 times, most recently
from
5810b60
to
63f9806
Compare
JayWhite2357
previously approved these changes
Jun 18, 2024
iajoiner
force-pushed
the
feat/generalize-dense-filter-expr
branch
from
63f9806
to
d9bf808
Compare
- Move `Expression` -> `ProvableExprPlan` to a separate struct, `ProvableExprPlanBuilder` since the process is no longer for where clauses only. - Add `EnrichedExpr` to be equivalent to the provable version of Expr in DataFusion - Allow arbitrary aliased provable expressions as result expressions in dense filters. - Remove constraints in `QueryContext` that prevents constants from being used in select.
iajoiner
force-pushed
the
feat/generalize-dense-filter-expr
branch
from
d9bf808
to
1904526
Compare
JayWhite2357
approved these changes
Jun 18, 2024
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It is necessary to move provable projections into the prover so that provable queries do not need postprocessing. This is the first PR of the change which is to move provable projections to the prover for filter queries.
What changes are included in this PR?
Expression->ProvableExprPlanto a separate struct,ProvableExprPlanBuildersince the process is no longer for where clauses only.EnrichedExprto be equivalent to the provable version of Expr in DataFusion for tamperproof queries.QueryContextthat prevents constants from being used in select.Are these changes tested?
Existing tests should pass. New tests will be added to cover nontrivial results such as
select a and b as c, d, 4 as f from tab where d = e.