Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing fields from sources and params #20

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Implement missing fields from sources and params #20

merged 2 commits into from
Jan 3, 2018

Conversation

nathmclean
Copy link
Collaborator

Contains breaking changes to dashboards - see CHANGELOG.md

Implements LIST and DYNAMIC parameter types.

Adds missing fields to sources.

resolve #18 resolve #17

louism517
louism517 approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@louism517 louism517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nathmclean nathmclean merged commit b5a97e5 into master Jan 3, 2018
MikeMcMahon pushed a commit to MikeMcMahon/terraform-provider-wavefront that referenced this pull request Feb 9, 2018
@nathmclean
Implement missing fields from sources and params (spaceapegames#20)
6b9d588 
Contains breaking changes to dashboards - see CHANGELOG.md

Implements LIST and DYNAMIC parameter types.

Adds missing fields to sources.
@nathmclean nathmclean deleted the dashboard_improvements branch February 26, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louism517 louism517 louism517 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chart option for disabled = true/false? Dashboard parameter_type only supports SIMPLE?
2 participants
@nathmclean @louism517