Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DeafultTimeWindow and Height Factor for Dashboards #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sanoojm
Copy link
Contributor

@sanoojm sanoojm commented Jun 20, 2019

#45
Adding "default time window" and "Height factor" to dashboards.

@sanoojm
Copy link
Contributor Author

sanoojm commented Jun 21, 2019

Please review.

@louism517
Copy link
Contributor

Hi @sanoojm,

Thanks for your PR. Looks good apart from some of the tests. Could you:

  • Add a test for default_time_window in here and add to the sample HCL here

  • Test that height_factor has actually been set by adding a check here

Thanks

@sanoojm
Copy link
Contributor Author

sanoojm commented Jul 19, 2019

Hi @sanoojm,

Thanks for your PR. Looks good apart from some of the tests. Could you:

  • Add a test for default_time_window in here and add to the sample HCL here
  • Test that height_factor has actually been set by adding a check here

Thanks
@louism517
Thanks for reviewing. I have made the necessary changes.

@sanoojm
Copy link
Contributor Author

sanoojm commented Sep 24, 2019

@louism517 Could you please review and merge these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants