Skip to content

Commit

Permalink
Changed so bug report button opens github issues instead of email
Browse files Browse the repository at this point in the history
  • Loading branch information
spacecowboy committed Oct 9, 2024
1 parent cb0dcf4 commit 350f599
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ class BugReportKTest {

@Test
fun issuesIntentIsCorrect() {
val intent = openGitlabIssues()
val intent = openGithubIssues()

assertEquals(ACTION_VIEW, intent.action)
assertEquals(Uri.parse("https://gitlab.com/spacecowboy/Feeder/issues"), intent.data)
assertEquals(Uri.parse("https://github.com/spacecowboy/feeder/issues"), intent.data)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.Add
import androidx.compose.material.icons.filled.BugReport
import androidx.compose.material.icons.filled.CheckBox
import androidx.compose.material.icons.filled.CheckBoxOutlineBlank
import androidx.compose.material.icons.filled.Delete
import androidx.compose.material.icons.filled.DoneAll
import androidx.compose.material.icons.filled.Edit
import androidx.compose.material.icons.filled.Email
import androidx.compose.material.icons.filled.FilterList
import androidx.compose.material.icons.filled.ImportExport
import androidx.compose.material.icons.filled.Menu
Expand Down Expand Up @@ -151,7 +151,7 @@ import com.nononsenseapps.feeder.ui.compose.utils.onKeyEventLikeEscape
import com.nononsenseapps.feeder.ui.compose.utils.rememberIsItemMostlyVisible
import com.nononsenseapps.feeder.util.ActivityLauncher
import com.nononsenseapps.feeder.util.ToastMaker
import com.nononsenseapps.feeder.util.emailBugReportIntent
import com.nononsenseapps.feeder.util.openGithubIssues
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.delay
Expand Down Expand Up @@ -324,7 +324,7 @@ fun FeedScreen(
onSendFeedback = {
activityLauncher.startActivity(
openAdjacentIfSuitable = true,
intent = emailBugReportIntent(),
intent = openGithubIssues(),
)
},
onImport = {
Expand Down Expand Up @@ -819,7 +819,7 @@ fun FeedScreen(
},
leadingIcon = {
Icon(
Icons.Default.Email,
Icons.Default.BugReport,
contentDescription = null,
)
},
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/com/nononsenseapps/feeder/util/BugReport.kt
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ fun emailCrashReportIntent(throwable: Throwable): Intent =
addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
}

fun openGitlabIssues(): Intent =
fun openGithubIssues(): Intent =
Intent(ACTION_VIEW).also {
it.data = Uri.parse("https://gitlab.com/spacecowboy/Feeder/issues")
it.data = Uri.parse("https://github.com/spacecowboy/feeder/issues")
}

const val KOFI_URL = "https://ko-fi.com/spacecowboy"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
<string name="sort_newest_first">Newest first</string>
<string name="sort_oldest_first">Oldest first</string>
<string name="sort">Sort by</string>
<string name="send_bug_report">Send bug-report</string>
<string name="send_bug_report">Send bug report</string>
<string name="no_email_client">Could not open e-mail client</string>
<string name="touch_to_play_video">Touch to play video</string>
<string name="javascript">JavaScript</string>
Expand Down

0 comments on commit 350f599

Please sign in to comment.