Skip to content

Commit

Permalink
update comment on ReadableSearchSuggestionListItem
Browse files Browse the repository at this point in the history
  • Loading branch information
CampelloManuel committed Apr 28, 2024
1 parent 651ecfd commit 91e6db1
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions app/src/main/res/values-v26/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@

<!-- When users increase the text size in the accessibility settings, the search suggestions
popup cuts the text (it only shows the top half of the letters), because the height of the
"dropdown menu list item" is fixed somewhere. We solve the bug with this override of the style
used by "dropdown list items" such as the search suggestions -->
"dropdown menu list item" is fixed in:
androidx.appcompat.R.layout.abc_search_dropdown_item_icons_2line
We solve the bug with this override of the style used by "dropdown list items"
such as the search suggestions -->
<style name="ReadableSearchSuggestionListItem" parent="android:Widget.Material.DropDownItem">
<!-- we force the text to resize in order to fit the fixed height of the list item -->
<item name="android:autoSizeTextType">uniform</item>
Expand Down
6 changes: 4 additions & 2 deletions app/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,10 @@

<!-- When users increase the text size in the accessibility settings, the search suggestions
popup cuts the text (it only shows the top half of the letters), because the height of the
"dropdown menu list item" is fixed somewhere. We solve the bug with this override of the style
used by "dropdown list items" such as the search suggestions -->
"dropdown menu list item" is fixed in:
androidx.appcompat.R.layout.abc_search_dropdown_item_icons_2line
We solve the bug with this override of the style used by "dropdown list items"
such as the search suggestions -->
<style name="ReadableSearchSuggestionListItem" parent="android:Widget.Material.DropDownItem">
<!-- on API versions < 26 the bug is not present
and we don't have the API to fix it, anyway -->
Expand Down

0 comments on commit 91e6db1

Please sign in to comment.