Instructions to install plugin with LazyVim #21
Conversation
Port spaceduck from vim to lua
# v1.0.0 (2022-12-20) ## ✨ New Features - [`62bd408`](spaceduck-theme@62bd408) port basic spaceduck to lua - [`00cbec8`](spaceduck-theme@00cbec8) add lualine support ## 🐛 Bug Fixes - [`b351754`](spaceduck-theme@b351754) assert syntax_on existence properly and disable broken groups - [`ab971f0`](spaceduck-theme@ab971f0) fix errors in lualine support - [`73c45d1`](spaceduck-theme@73c45d1) remove unwanted character from StatusLineTermNC
Update window separator style
# [v1.0.1](spaceduck-theme/nvim@v1.0.0...v1.0.1) (2023-07-01) ## 🐛 Bug Fixes - [`5e95aa5`](spaceduck-theme@5e95aa5) Set proper style for window separator - [`c9307d1`](spaceduck-theme@c9307d1) Change window separator color from cream to dark_purple (Issues: [`spaceduck-theme#5`](spaceduck-theme#5))
📝 Add command to inspect highlight groups
✨ Add highlight for float border
# [v1.1.0](spaceduck-theme/nvim@v1.0.1...v1.1.0) (2023-12-29) ## ✨ New Features - [`a7aa1ea`](spaceduck-theme@a7aa1ea) Add highlight for float border (Issues: [`spaceduck-theme#1`](spaceduck-theme#1))
There was a problem hiding this comment.
Thanks for the contribution. I have a couple of feedbacks.
Thanks for adding the changelog generation as well. I'd rather see that in its own PR though, please for proper changelog clarity. Here we'd be mixing two different things in the same PR and the title shadows the changelog changes.
README.md
Outdated
| priority = 1000, | ||
| opts = { | ||
| options = { | ||
| globalstatus = true, |
There was a problem hiding this comment.
I also use globalstatus as well but that's rather a personal preference. It's not mandatory for people to use Spaceduck so I'd rather remove it.
README.md
Outdated
| return { | ||
| "nvim-lualine/lualine.nvim", | ||
| dependencies = { 'nvim-tree/nvim-web-devicons' }, | ||
| lazy = false, |
There was a problem hiding this comment.
On my side it works without lazy = false and priority = 1000, at least for lualine. If we want to keep it, shouldn't it be a priority less than spaceduck to make sure the theme is loaded first and then lualine?
README.md
Outdated
| @@ -51,13 +70,31 @@ We use semver on spaceduck so you can refer to a specific tag if you want instea | |||
| <img src="https://user-images.githubusercontent.com/32819563/111935037-3ab41d80-8a88-11eb-8797-2b6db14cbff8.png" alt="lualine replace mode screenshot"> | |||
| </center> | |||
|
|
|||
| ## PACKER | |||
There was a problem hiding this comment.
Can you capitalize just the first letter of the titles, please?
There was a problem hiding this comment.
Yes i can, but i preferred to change to hyperlinks, can you tell me if I leave it as it was and only capitalize the first letter of the titles?
There was a problem hiding this comment.
Check the modifications, any changes that are required send the comments and I will modify.
Be patient, I'm new to this, I don't know much about using Git, GitHub has never worked with them, with other people.
I only know how to create my own repositories and I create 2 branches, the main one and a development or beta branch, it is the first time I make a pull request.
README.md
Outdated
| return { | ||
| "nvim-lualine/lualine.nvim", | ||
| dependencies = { 'nvim-tree/nvim-web-devicons' }, | ||
| lazy = false, |
README.md
Outdated
| @@ -51,13 +70,31 @@ We use semver on spaceduck so you can refer to a specific tag if you want instea | |||
| <img src="https://user-images.githubusercontent.com/32819563/111935037-3ab41d80-8a88-11eb-8797-2b6db14cbff8.png" alt="lualine replace mode screenshot"> | |||
| </center> | |||
|
|
|||
| ## PACKER | |||
There was a problem hiding this comment.
Yes i can, but i preferred to change to hyperlinks, can you tell me if I leave it as it was and only capitalize the first letter of the titles?
README.md
Outdated
| priority = 1000, | ||
| opts = { | ||
| options = { | ||
| globalstatus = true, |
Add instructions to README.md to install spaceduck them with the plugin manager LazyVim .
Hi, this is the first time I make a pull request, I'm still learning.