Test for empty subdir when searching for stacks #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking to see if it was possible to default the stack ID to an environment variable and found #60 but also found #125 had recently been merged so it should figure it out from the underlying cloned git repository. A new release hadn't been cut with this functionality so I tried building from source. I found
spacectl
still couldn't figure out the stack ID automatically.All of my stacks map 1:1 with their own separate repository so the project root is unset. I found I needed to apply this small patch in order for the search to return any results.
Also, it currently always prompts me to pick the stack from the search results, even if there's only ever 1 stack returned. This looks to be caused by this condition:
spacectl/internal/cmd/stack/stack_selector.go
Line 68 in d36ea75
forcePrompt
is alwaystrue
so it doesn't matter how many search results have been returned.