Use all relevant ignore files in archive matcher #139
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried doing #138 to pass time. Most explanation is in the commit message.
But for a quick skim, start at the diff for
internal/cmd/module/local_preview.go
orinternal/cmd/stack/local_preview.go
. Specifically at thematchFn
function.I cannot test this because I don't have an account, and the free account sounds like a 14-day trial.
Also I'm probably missing a lot of context from the project so it's likely I'm overcomplicating this.
I hope this PR is at least a bit helpful, but if not, feel free to reject.
Also, I could not build the project at first because the required version of
github.com/marcinwyszynski/graphql
didn't exist (!?). I had to fix it before I could even build themain
branch.