Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass state version when getting run logs #162

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

tomasmik
Copy link
Contributor

@tomasmik tomasmik commented Jul 20, 2023

We've added to repeat the same state for a run which requires you to provide the state version when getting logs. This adds the state version to the request.

@tomasmik tomasmik marked this pull request as ready for review July 20, 2023 09:30
@tomasmik tomasmik self-assigned this Jul 20, 2023
Copy link
Contributor

@mbialon mbialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice if the PR had some information about why we're doing this.

@tomasmik
Copy link
Contributor Author

LGTM. It would be nice if the PR had some information about why we're doing this.

Fair. Added.

@tomasmik tomasmik merged commit 0b9ce9b into main Jul 20, 2023
9 checks passed
@tomasmik tomasmik deleted the always-pass-state-version branch July 20, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants