Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve user facing error massage when the stack is not found #182

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Improve user facing error massage when the stack is not found #182

merged 8 commits into from
Sep 29, 2023

Commits on Sep 29, 2023

  1. chore: improve user facing error massage when the stack is not found 

    Signed-off-by: Michal Wasilewski <[email protected]>
    @mwasilew2
    mwasilew2 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    86a86c3 View commit details
    Browse the repository at this point in the history

  2. feat: check for stack presence when extracting stack id 

    Signed-off-by: Michal Wasilewski <[email protected]>
    @mwasilew2
    mwasilew2 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e8f4b3c View commit details
    Browse the repository at this point in the history

  3. Update internal/cmd/stack/stack_selector.go 

    Co-authored-by: Tomas <[email protected]>
    @mwasilew2 @tomasmik
    mwasilew2 and tomasmik authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    5e4b1f5 View commit details
    Browse the repository at this point in the history

  4. fix: let the caller decide what to do with the result 

    Signed-off-by: Michal Wasilewski <[email protected]>
    @mwasilew2
    mwasilew2 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8a3c9dd View commit details
    Browse the repository at this point in the history

  5. fix: simplify return logic 

    Signed-off-by: Michal Wasilewski <[email protected]>
    @mwasilew2
    mwasilew2 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d75a4b2 View commit details
    Browse the repository at this point in the history

  6. fix: linting issues 

    Signed-off-by: Michal Wasilewski <[email protected]>
    @mwasilew2
    mwasilew2 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a2eebdf View commit details
    Browse the repository at this point in the history

  7. chore: fix import ordering 

    Signed-off-by: Michal Wasilewski <[email protected]>
    @mwasilew2
    mwasilew2 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9abd652 View commit details
    Browse the repository at this point in the history

  8. chore: dont capitlize errors 

    Signed-off-by: Michal Wasilewski <[email protected]>
    @mwasilew2
    mwasilew2 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    bdda805 View commit details
    Browse the repository at this point in the history