Skip to content

Commit

Permalink
Update CHANGELOG
Browse files Browse the repository at this point in the history
  • Loading branch information
fasmat committed May 20, 2024
1 parent 97a2c79 commit 1ad0b78
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 13 deletions.
58 changes: 46 additions & 12 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ is macOS 14 (Sonoma) or later ([#5879](https://github.com/spacemeshos/go-spaceme

This update removes migration code for go-spacemesh databases created with versions before v1.5.0.
Upgrading to this version requires going through v1.5.x first. Removed migrations for:
* legacy keys in the post data directory ([#5907](https://github.com/spacemeshos/go-spacemesh/pull/5907)).
* ATX blob separation and always populating nonce column in atxs ([#5942](https://github.com/spacemeshos/go-spacemesh/pull/5942))

* legacy keys in the post data directory ([#5907](https://github.com/spacemeshos/go-spacemesh/pull/5907)).
* ATX blob separation and always populating nonce column in atxs ([#5942](https://github.com/spacemeshos/go-spacemesh/pull/5942))

### Highlights

Expand All @@ -32,22 +33,47 @@ Upgrading to this version requires going through v1.5.x first. Removed migration

* [#5888](https://github.com/spacemeshos/go-spacemesh/pull/5888) Handle DHT discovery startup errors properly

* [#5896](https://github.com/spacemeshos/go-spacemesh/pull/5896) Increase supported number of ATXs to 4.5 Mio.
* [#5958](https://github.com/spacemeshos/go-spacemesh/pull/5958) Fix node incorrectly detecting a remote smeshing setup
as supervised.

Ensure that your key file in `data/identities` is named `local.key` if you run a supervised node or with the change
the node will not start.

## Release v1.5.3

### Improvements

* [#5929](https://github.com/spacemeshos/go-spacemesh/pull/5929) Fix "no nonce" error when persisting malicious
(initial) ATXs.

* [#5930](https://github.com/spacemeshos/go-spacemesh/pull/5930) Check if identity for a given malfeasance proof
exists when validating it.

## Release v1.5.2-hotfix1

This release includes our first CVE fix. A vulnerability was found in the way a node handles incoming ATXs. We urge all
node operators to update to this version as soon as possible.

### Improvements

* Fixed a vulnerability in the way a node handles incoming ATXs. This vulnerability allows an attacker to claim rewards
for a full tick amount although they should not be eligible for them.

## Release v1.5.2

### Improvements

* [#5904](https://github.com/spacemeshos/go-spacemesh/pull/5904) Avoid repeated searching for positioning ATX in 1:N

* [#5911](https://github.com/spacemeshos/go-spacemesh/pull/5911) Avoid pulling poet proof multiple times in 1:N setups

* [#5923](https://github.com/spacemeshos/go-spacemesh/pull/5923) Fix high memory consumption and performance issues
in the proposal handler
## Release v1.5.1

* [#5932](https://github.com/spacemeshos/go-spacemesh/pull/5932) Fix caching malfeasance when processing new proofs

* [#5943](https://github.com/spacemeshos/go-spacemesh/pull/5943) Fix timing out querying proof in 1:N in a presence of a broken Poet.
### Improvements

Previously, every identitiy waited for the full timeout time (~20 minutes) before giving up.
* [#5896](https://github.com/spacemeshos/go-spacemesh/pull/5896) Increase supported number of ATXs to 4.5 Mio.

## (v1.5.0)
## Release v1.5.0

### Upgrade information

Expand All @@ -64,7 +90,15 @@ coins. Fixes an oversight in the genesis VM implementation.
* [#5791](https://github.com/spacemeshos/go-spacemesh/pull/5791) Speed up ATX queries.
This also fixes ambiguity of nonces for equivocating identities.

* [#5856](https://github.com/spacemeshos/go-spacemesh/pull/5856) Bump github.com/spacemeshos/api/release/go to v1.37.0.
* [#5923](https://github.com/spacemeshos/go-spacemesh/pull/5923) Fix high memory consumption and performance issues
in the proposal handler

* [#5932](https://github.com/spacemeshos/go-spacemesh/pull/5932) Fix caching malfeasance when processing new proofs

* [#5943](https://github.com/spacemeshos/go-spacemesh/pull/5943) Fix timing out querying proof in 1:N in a presence of
a broken Poet.

Previously, every identity waited for the full timeout time (~20 minutes) before giving up.

## Release v1.4.6

Expand Down Expand Up @@ -280,7 +314,7 @@ Make sure to replace `provider` with your provider of choice and `numUnits` with
initialize. The `commitmentAtxId` is the commitment ATX ID for the identity you want to initialize. For details on the
usage of `postcli` please refer to [postcli README](https://github.com/spacemeshos/post/blob/develop/cmd/postcli/README.md).

During initialization `postcli` will generate a new private key and store it in the PoST data directory as `identity.key`.
During initialization `postcli` will generate a new private key and store it in the PoST data directory as `local.key`.
Copy this file to your `data/identities` directory and rename it to `xxx.key` where `xxx` is a unique identifier for
the identity. The node will automatically pick up the new identity and manage its lifecycle after a restart.

Expand Down
7 changes: 6 additions & 1 deletion node/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -1659,7 +1659,12 @@ func (app *App) startAPIServices(ctx context.Context) error {
return errors.New("smeshing enabled but no coinbase account provided")
}
if len(app.signers) > 1 || app.signers[0].Name() != supervisedIDKeyFileName {
return errors.New("supervised smeshing cannot be started in a remote or multi-smeshing setup")
app.log.Error("supervised smeshing cannot be started in a remote or multi-smeshing setup")
app.log.Error(
"if you run a supervised node ensure your key file is named %s and try again",
supervisedIDKeyFileName,
)
return errors.New("smeshing enabled in remote setup")

Check warning on line 1667 in node/node.go

View check run for this annotation

Codecov / codecov/patch

node/node.go#L1662-L1667

Added lines #L1662 - L1667 were not covered by tests
}
if err := app.postSupervisor.Start(
app.Config.POSTService,
Expand Down

0 comments on commit 1ad0b78

Please sign in to comment.