[Merged by Bors] - Verify that previous ATX points to correct ATX when handling incoming ATXs #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All identities within the node register in the same poets so there's no need to fetch the proof many times.
It avoids duplicated work to look up a positioning ATX and verify its chain.
## Motivation Follow up to #5821. Add `.netrc` creation to workflow for creating docker release images
… ATXs (#27) --------- Co-authored-by: Bartosz Różański <[email protected]>
fasmat
force-pushed
the
cve-fix-integration
branch
from
766ab41
to
5222e1d
Compare
* Fix ATX handling of double initial ATXs
fasmat
force-pushed
the
cve-fix-integration
branch
from
a3b8dcd
to
0d2e5c3
Compare
* Check if identity exists when validating incoming malfeasance proofs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5927 +/- ##
=========================================
- Coverage 80.8% 80.8% -0.1%
=========================================
Files 286 287 +1
Lines 29714 29905 +191
=========================================
+ Hits 24035 24182 +147
- Misses 4117 4139 +22
- Partials 1562 1584 +22 ☔ View full report in Codecov by Sentry. |
|
bors try |
poszu
approved these changes
May 21, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 21, 2024
… ATXs (#5927) ## Motivation This integrates the changes from the CVE fix into the main development branch. Closes #5692 Co-authored-by: Bartosz Różański <[email protected]>
|
Build failed (retrying...): |
|
Canceled. |
|
bors merge |
|
Merge conflict. |
fasmat
force-pushed
the
cve-fix-integration
branch
from
fb408b1
to
ff55625
Compare
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 21, 2024
… ATXs (#5927) ## Motivation This integrates the changes from the CVE fix into the main development branch. Closes #5692 Co-authored-by: Bartosz Różański <[email protected]>
|
Build failed: |
|
test timeout bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 21, 2024
… ATXs (#5927) ## Motivation This integrates the changes from the CVE fix into the main development branch. Closes #5692 Co-authored-by: Bartosz Różański <[email protected]>
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 22, 2024
Cherry pick of #5927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This integrates the changes from the CVE fix into the main development branch.
Closes #5692
Description
For details see: GHSA-jcqq-g64v-gcm7
Test Plan
Tests have been added to verify new / changed code.
TODO