-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Verify that previous ATX points to correct ATX when handling incoming ATXs #5927
Conversation
All identities within the node register in the same poets so there's no need to fetch the proof many times.
It avoids duplicated work to look up a positioning ATX and verify its chain.
## Motivation Follow up to #5821. Add `.netrc` creation to workflow for creating docker release images
… ATXs (#27) --------- Co-authored-by: Bartosz Różański <[email protected]>
766ab41
to
5222e1d
Compare
* Fix ATX handling of double initial ATXs
a3b8dcd
to
0d2e5c3
Compare
* Check if identity exists when validating incoming malfeasance proofs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5927 +/- ##
=========================================
- Coverage 80.8% 80.8% -0.1%
=========================================
Files 286 287 +1
Lines 29714 29905 +191
=========================================
+ Hits 24035 24182 +147
- Misses 4117 4139 +22
- Partials 1562 1584 +22 ☔ View full report in Codecov by Sentry. |
bors try |
bors merge |
… ATXs (#5927) ## Motivation This integrates the changes from the CVE fix into the main development branch. Closes #5692 Co-authored-by: Bartosz Różański <[email protected]>
Build failed (retrying...): |
Canceled. |
bors merge |
Merge conflict. |
fb408b1
to
ff55625
Compare
bors merge |
… ATXs (#5927) ## Motivation This integrates the changes from the CVE fix into the main development branch. Closes #5692 Co-authored-by: Bartosz Różański <[email protected]>
Build failed: |
test timeout bors merge |
… ATXs (#5927) ## Motivation This integrates the changes from the CVE fix into the main development branch. Closes #5692 Co-authored-by: Bartosz Różański <[email protected]>
Pull request successfully merged into develop. Build succeeded: |
Cherry pick of #5927
Motivation
This integrates the changes from the CVE fix into the main development branch.
Closes #5692
Description
For details see: GHSA-jcqq-g64v-gcm7
Test Plan
Tests have been added to verify new / changed code.
TODO