Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP: Add invalid post malfeasance #6308

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 29, 2024

Motivation

Closes #6141

Description

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Aug 29, 2024
@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch from 3e94b7e to 39883a2 Compare August 29, 2024 19:46
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 3.73832% with 206 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (2439e4c) to head (8b03b3f).

Files with missing lines Patch % Lines
activation/wire/malfeasance_invalid_post.go 0.0% 193 Missing ⚠️
activation/validation.go 0.0% 10 Missing and 1 partial ⚠️
signing/signer.go 0.0% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6308     +/-   ##
=========================================
- Coverage     79.7%   79.4%   -0.4%     
=========================================
  Files          328     329      +1     
  Lines        42983   43189    +206     
=========================================
+ Hits         34280   34305     +25     
- Misses        6768    6949    +181     
  Partials      1935    1935             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch from efe056f to 28a5fb1 Compare September 9, 2024 08:23
@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch 3 times, most recently from 99f15b6 to e84b2f5 Compare September 27, 2024 14:04
@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch 2 times, most recently from 47e2b58 to 65dd8b6 Compare October 9, 2024 08:13
@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch 2 times, most recently from 76edcc7 to b64cf35 Compare October 15, 2024 18:52
@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch 2 times, most recently from 541673b to 86f4785 Compare October 26, 2024 12:09
@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch from 8581dec to 31d654b Compare October 30, 2024 17:52
@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch from 31d654b to 1e084ad Compare October 30, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malfeasance V2: Invalid Post
1 participant