-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - atx: cache poet proofs with lru #6336
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6336 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 312 312
Lines 34606 34637 +31
=========================================
+ Hits 28314 28328 +14
- Misses 4461 4472 +11
- Partials 1831 1837 +6 ☔ View full report in Codecov by Sentry. |
@poszu updated with singleflight just in case, could you please check again? |
bors try |
tryBuild failed: |
bors merge |
followup for #6326 in current code poet proofs are fetched for every atx submitted to the node, they are relatively large (140KB) and account for sizeable chunk of all reads executed on the atx handler codepath (25%). they are also a perfect case for lru caching, they are mostly reused and replaced from epoch to epoch. basic stats in recent epochs. ``` select round_id, count(*), max(length(poet)) from poets group by round_id; 25|42|146200 26|45|145936 27|45|145738 28|45|145903 ```
Pull request successfully merged into develop. Build succeeded: |
followup for #6326
in current code poet proofs are fetched for every atx submitted to the node,
they are relatively large (140KB) and account for sizeable chunk of all reads executed on the atx handler codepath (25%).
they are also a perfect case for lru caching, they are mostly reused and replaced from epoch to epoch.
basic stats in recent epochs.