sql: identities contain large proofs so tree without rowid will be slow to scan #6337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
requested review from
fasmat,
poszu,
ivan4th and
acud
as code owners
dshulyak
changed the title
dshulyak
changed the title
From what I understand this PR adds rowid not removes it |
dshulyak
changed the title
|
@ivan4th thanks it was a typo, i updated title |
|
i will merge it with another change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup for #6326
it is the first part of fixing IsMalicious, the main culprit is the query that includes marriage_atx check.
i will address it either here or in separate change.