Athena: Initial POC integration #6380
Draft
+3,723
−3,495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is being moved into the VM, or refactored here
and mock a few things while we wait for them to be implemented in Athena
We may need this later, to pass into the VM template
Host tests passing
Remove unneeded scaffolding
GetBalance test WIP
Upgrade to latest athena bindings Fix host call logic
poszu
reviewed
Oct 22, 2024
Untested so far
Update athena go binding
fix encoding of verify args
Remove duplicate spawn, transfer, principal calculation logic Make linter happy
and regenerate
Fix some small bugs found in testing
For now, Athena calculates principal using the encoded wallet state blob, rather than just the pubkey/payload like we were doing here. Do the same here, for now. Remove Payload from tx header; it's stored in context
Ensure that host and all VM logic are using the same cache
Update some node-wide interfaces. Begin to integrate new VM into API.
Use a cloned host for MaxSpend, Verify, and Verify spawn
Some more fixes to byte wrangling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replace existing genvm functionality with athena
Description
vmcodevmtemplate-related code with calls into athenaTest Plan
tbd
TODO