Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node-split] Upgrade to go 1.24 #6772

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Mar 6, 2025

Motivation

This is a port of #6722 for the node-split branch

Description

I cherry picked the squashed commit from the original branch and fixed all conflicts. Additionally I updated the new code on this branch to adhere to the new linting rules

Test Plan

existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Mar 6, 2025
@fasmat fasmat changed the title Upgrade to go 1.24 [Node-split] Upgrade to go 1.24 Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1%. Comparing base (e1785c0) to head (072b655).
Report is 3 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##           node-split-poc   #6772     +/-   ##
================================================
- Coverage            75.1%   75.1%   -0.1%     
================================================
  Files                 395     395             
  Lines               55042   55044      +2     
================================================
- Hits                41387   41358     -29     
- Misses              11125   11149     +24     
- Partials             2530    2537      +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat merged commit 5be1110 into node-split-poc Mar 6, 2025
16 checks passed
@fasmat fasmat deleted the node-split-poc-go-1.24 branch March 6, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants