Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VoiceOver and Voice Control experienence #211

Merged
merged 8 commits into from
May 15, 2024
+87 −20
Merged

Improve VoiceOver and Voice Control experienence #211

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf7bccc
Settings: Add button trait
fbernutz May 15, 2024
b04bf41
Improve VoiceOver on Detail ViewController
fbernutz May 15, 2024
10999d1
Use formatter for duration when possible
fbernutz May 15, 2024
22a5389
Add button accessibility trait to all movie cells
fbernutz May 15, 2024
d87e7cf
Add more granular context for release date in VoiceOver announcement
fbernutz May 15, 2024
010d184
Split between accessibilityLabel and accessibilityValue
fbernutz May 15, 2024
532d995
Fix Xcode warning
fbernutz May 15, 2024
51339ad
Fix condition in formatter
fbernutz May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add button accessibility trait to all movie cells
@fbernutz
fbernutz committed May 15, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 22a5389c1ac96d93746510cbbfda1c5440d30895
1 change: 1 addition & 0 deletions Cineaste/ViewController/Movies/SeenMovieCell.swift
View file
Original file line number Diff line number Diff line change
@@ -43,6 +43,7 @@ class SeenMovieCell: UITableViewCell {

private func applyAccessibility(for movie: Movie) {
isAccessibilityElement = true
accessibilityTraits.insert(.button)

accessibilityLabel = movie.title

1 change: 1 addition & 0 deletions Cineaste/ViewController/Movies/WatchlistMovieCell.swift
View file
Original file line number Diff line number Diff line change
@@ -52,6 +52,7 @@ class WatchlistMovieCell: UITableViewCell {

private func applyAccessibility(for movie: Movie) {
isAccessibilityElement = true
accessibilityTraits.insert(.button)

accessibilityLabel = movie.title

1 change: 1 addition & 0 deletions Cineaste/ViewController/SearchMovies/SearchMoviesCell.swift
View file
Original file line number Diff line number Diff line change
@@ -68,6 +68,7 @@ class SearchMoviesCell: UITableViewCell {

private func applyAccessibility(for movie: Movie) {
isAccessibilityElement = true
accessibilityTraits.insert(.button)

accessibilityLabel = movie.title